Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In case of project have no Frameworks group, raise a meaningful error. #431

Merged
merged 1 commit into from Aug 1, 2012

Conversation

siuying
Copy link
Contributor

@siuying siuying commented Jul 31, 2012

In the case of #326, instead of default crash log, raise a meaningful error message.

Generating support files
-> Integrating `libPods.a' into target `Pulsar' of Xcode project `Pulsar.xcodeproj'.
[!] Cannot add pod library to project. Please check if the project have a 'Frameworks' group in the root of the project.

@travisbot
Copy link

This pull request passes (merged 02d28e4 into 58bea1e).

@fabiopelosin
Copy link
Member

Looks good. I'm merging it. @siuying Can you document this in the changelog?

fabiopelosin added a commit that referenced this pull request Aug 1, 2012
In case of project have no Frameworks group, raise a meaningful error.
@fabiopelosin fabiopelosin merged commit 6654114 into CocoaPods:master Aug 1, 2012
siuying added a commit that referenced this pull request Aug 3, 2012
@siuying
Copy link
Contributor Author

siuying commented Aug 3, 2012

Added in 799e0af !

@fabiopelosin
Copy link
Member

Thanks!

alloy added a commit that referenced this pull request Aug 10, 2012
…#431

Better to allow the user to choose how to organize her project.
@alloy
Copy link
Member

alloy commented Aug 10, 2012

I think it’s better that we allow the user to decide how to organise her project. Fixed in eef9d51.

fabiopelosin added a commit that referenced this pull request Aug 13, 2012
* master:
  [Excutable] Fix for ruby 1.8.7.
  [CHANGELOG] Didn't realize that github already adds a separator line for each entry.
  [CHANGELOG] Update
  Add static libraries to root of project if no Frameworks group exists. #431
  Cleanup a little by using ActiveSupport convenience methods.
  CHANGELOG.md
  [Documentation] Use public headers if specified.
  [Downloader] raise when importan commands fail.
  [Git] Init submodules only if requested.
  [Rakefile] commit Gemfile.lock on release.
  [Changelog] Release 0.11.1.
  Release 0.11.1
  [Changelog] Update.
fabiopelosin added a commit that referenced this pull request Oct 25, 2014
In case of project have no Frameworks group, raise a meaningful error.
siuying added a commit that referenced this pull request Oct 25, 2014
alloy added a commit that referenced this pull request Oct 25, 2014
…#431

Better to allow the user to choose how to organize her project.
fabiopelosin added a commit that referenced this pull request Oct 25, 2014
* master:
  [Excutable] Fix for ruby 1.8.7.
  [CHANGELOG] Didn't realize that github already adds a separator line for each entry.
  [CHANGELOG] Update
  Add static libraries to root of project if no Frameworks group exists. #431
  Cleanup a little by using ActiveSupport convenience methods.
  CHANGELOG.md
  [Documentation] Use public headers if specified.
  [Downloader] raise when importan commands fail.
  [Git] Init submodules only if requested.
  [Rakefile] commit Gemfile.lock on release.
  [Changelog] Release 0.11.1.
  Release 0.11.1
  [Changelog] Update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants